Fix mapping from slider values to menu items.#34
Open
garthk wants to merge 1 commit intogeekscape:masterfrom
Open
Fix mapping from slider values to menu items.#34garthk wants to merge 1 commit intogeekscape:masterfrom
garthk wants to merge 1 commit intogeekscape:masterfrom
Conversation
garthk
force-pushed
the
fix/system_ui_slider_menu
branch
from
c70e1a3 to
1d39d72
Compare
garthk
force-pushed
the
fix/system_ui_slider_menu
branch
from
1d39d72 to
a7eb032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distributes inputs in the range 0..100 evenly across the menu items, fixing a bug making it almost impossible to select the first item.
I'm happy with the logic. I'm sure there's a shorter, clearer version of the expression in slider_zone. I'm very sure the slider_zone function belongs elsewhere; @geekscape do you want to move it yourself afterward, or should I move it now?