Fixed: Can't add new notifications in the theme's functions.php file#61
Open
romangaina wants to merge 2 commits intogedex:masterfrom
romangaina:master
Open
Fixed: Can't add new notifications in the theme's functions.php file#61romangaina wants to merge 2 commits intogedex:masterfrom romangaina:master
romangaina wants to merge 2 commits intogedex:masterfrom
romangaina:master
Conversation
added 2 commits
August 1, 2017 23:49
Because the code fired after the plugins loaded, but before the theme itself loaded - you couldn't add custom notifications in your functions.php file (or other theme's file).
Changing the code to fire after the theme has loaded fixed it.
Workaround - Just add this in your functions.php if you want to have the original plugin installed without modifications:
// Runs this plugin after the theme is loaded.
add_action( 'after_setup_theme', function() {
$GLOBALS['wp_slack'] = new WP_Slack_Plugin();
$GLOBALS['wp_slack']->run( __FILE__ );
});
…ns.php Fixed: Can't add new notification in functions.php
jay-oswald
approved these changes
Jan 11, 2018
jay-oswald
left a comment
jay-oswald
left a comment
There was a problem hiding this comment.
This is a needed changs, failed build for unrelated issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.