Skip to content

Improve comments#43

Open
macbookandrew wants to merge 3 commits intogedex:masterfrom
macbookandrew:improve-comments
Open

Improve comments#43
macbookandrew wants to merge 3 commits intogedex:masterfrom
macbookandrew:improve-comments

Conversation

@macbookandrew
Copy link
Copy Markdown
Contributor

Makes comment notification a bit more reliable with third-party comment systems such as Epoch and adds moderation links similar to the native WP emails.

Improves compatibility with third-party plugins who may not use wp_insert_comment; comment_post is run when a comment is inserted into the database, so more plugins should use that. Those using their own insert code would hopefully provide action hooks that could be used to add notifications.
@gedex
Copy link
Copy Markdown
Owner

gedex commented Jan 5, 2017

I like the moderation links. However not sure if wp_insert_comment should be changed to comment_post. The wp_new_comment func (in which comment_post defined) calls wp_insert_comment func which also triggers wp_insert_comment action. I assume without changing the hook it should notifies when a comment, via Epoch, is added to the DB, yes?

@macbookandrew
Copy link
Copy Markdown
Contributor Author

Good point. Seems like it should work without that change, but for some reason it didn’t. At this point, I can’t recall why 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants