BiomeE attenuate aggressive cohort fusion#327
Open
fabern wants to merge 12 commits into
Open
Conversation
Previously, cohorts within 20% relative DBH difference were merged. This has been reduced to 2%, with the aim to enable comparison with observed size distributions.
Thereby removing the more complicated relative threshold applied previously.
Colum order of these variables was wrong: "NSN","seedC","leafC","rootC","sapwoodC","heartwoodC"
Caused by warning: ! `case_match()` was deprecated in dplyr 1.2.0. i Please use `recode_values()` instead.
── Failure ('test-model-runs.R:64:3'): biomee output check (gs leuning) ────────
Expected `all.equal(...)` to be TRUE.
Differences:
`actual` is a character vector ('Mean relative difference: 0.0002914499')
`expected` is a logical vector (TRUE)
Following deprecation warnings starting with devtools 2.5.0 and following the instructions on https://devtools.r-lib.org/reference/install-deprecated.html
Member
Author
|
This can be merged into the main branch. Note: CI issue on @stineb, please have a look at the changes. They are summarised in Lines 2 to 6 in adb62a5 |
Member
Author
|
Collaborator
|
To do: tests, avoid excessive merging of small cohorts (ingrowth) when growth is <1 cm/yr. Implications of relative vs absolute merging criterium for dynamics? Relative may be more robust for dealing with small cohorts (understorey growth) and under conditions of generally low growth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch:
seedC,leafC,rootC,sapwoodC,heartwoodC, andNSN(BiomeE cohort output mixes variable names #325)