Enable BiomeE likelihood for calibration with a) multiple targets and b) multiple sites#233
Closed
fabern wants to merge 21 commits into
Closed
Enable BiomeE likelihood for calibration with a) multiple targets and b) multiple sites#233fabern wants to merge 21 commits into
fabern wants to merge 21 commits into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BiomeE likelihood function was very basic, mainly a hardcoded proof-of-concept but not flexible enough to apply to multiple sites or multiple target variables.
This PR updates this.
This PR further serves as a opportunity to streamline the likelihoods/RMSE calculations and properly applying the DRY principle (reducing the repeated code).
pred_obsresult fromlikelihoodHelper_combine_model_obs()into a single, long data.frame()verbose=FALSEfrom PR: Minor changes #217This is not only relevant for BiomeE but also changing the calibration of p-model to use ET instead/in addition to GPP. Hence this is also related to: geco-bern/sofunCalVal#5 and geco-bern/sofunCalVal#17