Skip to content

fix(ethexe-ethereum): temporarily do not call gas estimate#5072

Merged
breathx merged 4 commits intomasterfrom
av/fix-batch-commit
Jan 26, 2026
Merged

fix(ethexe-ethereum): temporarily do not call gas estimate#5072
breathx merged 4 commits intomasterfrom
av/fix-batch-commit

Conversation

@StackOverflowExcept1on
Copy link
Copy Markdown
Member

No description provided.

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR labels Jan 15, 2026
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Jan 15, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  ethexe/ethereum/src/router/mod.rs  11% smaller

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @StackOverflowExcept1on, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a temporary fix by disabling the gas estimation mechanism within the Ethereum router. The change replaces the dynamic calculation of transaction gas limits with a fixed, large gas limit. This modification aims to circumvent potential issues or inefficiencies with the current gas estimation process, ensuring that transactions can proceed without being hindered by estimation failures.

Highlights

  • Gas Estimation Disabled: The logic responsible for dynamically estimating gas for transactions has been temporarily removed.
  • Fixed Gas Limit: Transactions will now use a predefined HUGE_GAS_LIMIT instead of a calculated estimate.
  • State Override Removal: The associated state override mechanism, previously used in conjunction with gas estimation, has also been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables gas estimation for commit_batch_pending calls, falling back to a hardcoded HUGE_GAS_LIMIT. While this is a valid temporary fix as indicated by the PR title, it's important to document this change in the code to ensure it's reverted later. I've suggested adding a TODO comment to track this.

Comment thread ethexe/ethereum/src/router/mod.rs
@breathx breathx merged commit af20fdd into master Jan 26, 2026
32 of 33 checks passed
@breathx breathx deleted the av/fix-batch-commit branch January 26, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team D8-ethexe ethexe-related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants