enable gfp testing, add gfp to dependencies

[ThomasPluck]

After dialogue with @flaport GFP_API_KEY secret has been added to the GDSFactory Organisation - so we can re-enable GFP testing and add GFP to the list of dependencies in the FOSS PDK.

Not exposing these GFP tests through make test/test-force is the right call as FOSS users might not have/want GFP keys :)

Summary by Sourcery

Enable GFP testing in CI and update project dependencies and Python version requirements.

New Features:

• Add a dedicated CI job to run GFP tests via uv run gfp test.

Enhancements:

• Add gdsfactoryplus as a runtime dependency and require Python 3.12 or newer (but below 3.13).

CI:

• Introduce a new GitHub Actions workflow job test_gfp that installs dependencies and executes GFP tests separately from the main test job.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Re-enables GFP tests as a separate CI job and updates the package configuration to depend on gdsfactoryplus with a stricter Python version requirement, aligning the project with GFP-based testing in the FOSS PDK.

File-Level Changes

Change	Details	Files
Re-enable GFP tests in CI as a dedicated workflow job that runs GFP’s own test command.	Uncomment and activate the previously stubbed GFP test job in the GitHub Actions workflow. Configure the GFP job to run on ubuntu-latest with Python 3.12 via setup-python. Ensure dependencies are installed with make install before executing GFP tests. Execute GFP tests using uv run gfp test as the test step.	.github/workflows/test_code.yml
Add gdsfactoryplus as a required dependency and tighten the supported Python version range.	Add gdsfactoryplus==1.3.7 to the project’s core dependencies to support GFP usage in the FOSS PDK. Ensure dependency list remains valid TOML by adding a trailing comma to the preceding entry. Update requires-python to >=3.12,<3.13 to standardize on Python 3.12, matching CI configuration.	pyproject.toml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found:

[github-actions]

Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found:

[sourcery-ai]

Hey - I've left some high level feedback:

• In the new test_gfp job, the step name Test with pytest is misleading since it runs uv run gfp test; consider renaming the step to better reflect that it’s running GFP tests.
• You’ve pinned gdsfactoryplus to an exact version (==1.3.7); consider using a compatible range (e.g. ~=1.3.7) unless there’s a strong reason to lock it strictly, to reduce the risk of dependency conflicts in downstream environments.
• Since both test and test_gfp jobs install the same dependencies via make install, consider adding a shared cache step (e.g. for the uv/pip cache) to speed up CI runs and reduce redundant installs.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In the new `test_gfp` job, the step name `Test with pytest` is misleading since it runs `uv run gfp test`; consider renaming the step to better reflect that it’s running GFP tests.
- You’ve pinned `gdsfactoryplus` to an exact version (`==1.3.7`); consider using a compatible range (e.g. `~=1.3.7`) unless there’s a strong reason to lock it strictly, to reduce the risk of dependency conflicts in downstream environments.
- Since both `test` and `test_gfp` jobs install the same dependencies via `make install`, consider adding a shared cache step (e.g. for the `uv`/pip cache) to speed up CI runs and reduce redundant installs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ThomasPluck]

Well - the important stuff works