Skip to content

Added -vertical option to Dialog::Basic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jerome-diver wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added -vertical option to Dialog::Basic #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lib/Curses/UI/Dialog/Basic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use vars qw(
Curses::UI::Common
);

$VERSION = '1.10';
$VERSION = '1.11';

sub new ()
{
Expand All @@ -40,7 +40,7 @@ sub new ()
-border => 1,
-message => '', # The message to show
-ipad => 1,
-fg => -1,
-fg => -1,
-bg => -1,

%userargs,
Expand Down Expand Up @@ -69,15 +69,15 @@ sub new ()
-fg => $this->{-fg},
-bbg => $this->{-bg},
-bfg => $this->{-fg},
-focusable => 0,
-focusable => 0,
);

# Create a hash with arguments that may be passed to
# the Buttonbox class.
my %buttonargs = (
-buttonalignment => 'right',
);
foreach my $arg (qw(-buttons -selected -buttonalignment)) {
foreach my $arg (qw(-buttons -selected -buttonalignment -vertical)) {
$buttonargs{$arg} = $this->{$arg}
if exists $this->{$arg};
}
Expand Down Expand Up @@ -152,15 +152,17 @@ sub layout()
# new() calls SUPER::new()).
my $buttons = $this->getobj('buttons');
my $button_width = 0;
my $button_height = 0;
if (defined $buttons) {
$button_width = $buttons->compute_buttonwidth;
$button_height = $buttons->compute_buttonheight;
}

# Decide what is the longest line.
$longest_line = $button_width if $longest_line < $button_width;

# Check if there is enough space to show the widget.
if ($avail_textheight < 1 or $avail_textwidth < $longest_line) {
if ($avail_textheight < $button_height or $avail_textwidth < $longest_line) {
$Curses::UI::screen_too_small = 1;
return $this;
}
Expand All @@ -174,7 +176,7 @@ sub layout()
$w += $this->{-ipadleft} + $this->{-ipadright};

my $h = @lines;
$h += 2; # empty line + line of buttons
$h += 1 + $button_height; # empty line + number of lines of buttons
$h += 2; # border of textviewer
$h += 2 if $this->{-border};
$h += $this->{-ipadtop} + $this->{-ipadbottom};
Expand Down Expand Up @@ -276,6 +278,10 @@ These options sets the buttons that have to be used. For an
explanation of these options, see the
L<Curses::UI::Buttonbox|Curses::UI::Buttonbox> documentation.

=item * B<-vertical> < BOOLEAN >

Option to set vertical buttons added positions instead of default horizontal.

=back


Expand Down