# Bug fix - issue #49 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zipped files when there are a larger file (>MAXIMUM_PACKAGE_SIZE)
Member
|
@kenlhlui thanks for submitting the PR and the fix! I will be back from vacation on Monday and will review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix - issue #49
This PR fixes the bug where zip files were not being packaged (putting in the upload queue) correctly when there are larger files that exceed the maximum package size.
Changes made:
distribute_filesfunction indvuploader/packaging.pyto ensure that thecurrent_package(list) is not overwritten when a file exceeds the maximum package size. Instead, it appends the current package to the list of packages before resetting it for the next file.