6439: Throw clearer exception when tags malformed #6512
Conversation
…com:gchq/sleeper into 6439-admin-client-crash-when-tags-malformed
ca61688
added
the
needs-reviewer
| if (split.length % 2 != 0) { //Check for even number of tag name and values | ||
| throw new IllegalArgumentException("Tags element didn't contain an even number of elements." + | ||
| " Ensure each tag name and value are seperated by a comma."); | ||
| } |
There was a problem hiding this comment.
The admin client will still crash when this is thrown.
If the tags property value is invalid, it needs to fail during validation of the properties. Right now this failure is thrown while creating the InstanceProperties object, before we can call validate on the object.
When this is done through the admin client, we expect the validation failure to be caught in UpdatePropertiesRequest.getInvalidProperties. That finds out exactly which properties are invalid, and that's then displayed to the user in PropertiesDiff.print.
We need to provide unit test coverage for this somehow. I think the simplest approach would be to cover it in InstancePropertiesTest. We can call InstanceProperties.createWithoutValidation, with an invalid value for the tags property. We can assert that an exception is only thrown when you call InstanceProperties.validate. We can also assert that it should fail when you try to read the tags when they're invalid.
Sorry the information on the issue is a bit vague. I'll add more information there as well.
patchwork01
removed
the
needs-reviewer
Make sure you have checked all steps below.
Issue
Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
for your progress.
Tests
Documentation
separate issue for that below.