Skip to content

Comments

Refactor - Clean Code and S.O.L.I.D#4

Open
DanMke wants to merge 16 commits intodevelopfrom
refactor.clean-code-and-solid
Open

Refactor - Clean Code and S.O.L.I.D#4
DanMke wants to merge 16 commits intodevelopfrom
refactor.clean-code-and-solid

Conversation

@DanMke
Copy link
Member

@DanMke DanMke commented Nov 26, 2020 •
edited
Loading

Proposed changes

clean code application focused on avoiding duplication and distribution of responsibilities for applying the Single Responsibility Principle

Issue(s)

There is no specific issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre and others added 12 commits November 12, 2020 11:07
@djorkaeffalexandre
[FIX] Notification stream throwing an error when there isn't a messag…
ef67665 
…e on payload (RocketChat#2637)
@diegolmello
[FIX] Threads not being updated and other related issues (RocketChat#…
8cac766 
…2636)

* Fix parent title on thread header breaking lines

* Fix RocketChat#2519

* Fix thread badge not being updated
@diegolmello @djorkaeffalexandre
[FIX] Minor room header issues (RocketChat#2630)
264a589 
* Add hitSlop to RoomView header

* Use 1 icon padding for threads header

Co-authored-by: Djorkaeff Alexandre <djorkaeff.unb@gmail.com>
@jacotec @diegolmello
[FIX] Whitelabel unable to find package name (RocketChat#2626)
59a24a7 
* Fixes RocketChat#2625

* Fixes RocketChat#2614

* Apply resValue on defaultConfig and undo unnecessary changes

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@phriedrich @diegolmello
[i18n] Add missing German strings (RocketChat#2619)
b904097 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@diegolmello
[FIX] Model columns misplaced (RocketChat#2640)
80d6e0d
@djorkaeffalexandre @diegolmello
[FIX] Connect a null server (RocketChat#2639)
1f74ada 
Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre @diegolmello
[FIX] Jitsi users unable to unmute (RocketChat#2623)
7af4bbb 
* [FIX] Jitsi users being muted always

* fix: bundle is invalid

* Update jitsi meet sdk with ui improvements

* Update JitsiMeetSDK ios

* Centralize toolbox android

* Fix images on Jitsi

Co-authored-by: Diego Mello <diegolmello@gmail.com>
@djorkaeffalexandre
Bump version to 4.12.1 (RocketChat#2641)
079d239
@diegolmello
[FIX] Share extension and save image not working on Android 10 (Rocke…
ded7391 
…tChat#2651)
@diegolmello
Bump version to 4.13.0 (RocketChat#2657)
df7f395
@DanMke
refactor: solving duplications in state.js
61aeb82 
Signed-off-by: Daniel Maike <danmke@hotmail.com>
@DanMke DanMke self-assigned this Nov 26, 2020
@DanMke DanMke changed the title Refactor.clean code and solid Refactor - Clean Code and S.O.L.I.D Nov 26, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@DanMke DanMke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanMke @djorkaeffalexandre @diegolmello @jacotec @phriedrich