Skip to content

Comments

Refact lib#2

Open
lucasmidlhey wants to merge 3 commits intodevelopfrom
refact_lib
Open

Refact lib#2
lucasmidlhey wants to merge 3 commits intodevelopfrom
refact_lib

Conversation

@lucasmidlhey
Copy link

@lucasmidlhey lucasmidlhey commented Nov 26, 2020

Proposed changes

new room.js file applying SOLID principles.
refactoring name of methods and consts aplying clean code in everyone.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lucasmidlhey lucasmidlhey self-assigned this Nov 26, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant