Fixed bug where objects inside a package/namespace would corrupt the …#64
Open
Ivanmatthew wants to merge 2 commits intogbaychev:masterfrom
Open
Fixed bug where objects inside a package/namespace would corrupt the …#64Ivanmatthew wants to merge 2 commits intogbaychev:masterfrom
Ivanmatthew wants to merge 2 commits intogbaychev:masterfrom
Conversation
…file after deleting it
Ivanmatthew
commented
Sep 20, 2022
Author
Ivanmatthew
left a comment
Ivanmatthew
left a comment
There was a problem hiding this comment.
Both changes make sure corrupted files become uncorrupted, and new files will not corrupt from relation to this bug.
I have explicitly kept in the container adding, even if it has no child nodes, as I'm afraid it might break something long term.
Owner
|
Thank you for the PR/fix, I'll try to merge it after the holidays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objects visually placed inside a package/namespace using NClass, will error, as the serializer converts the index integer of the deleted object to -1, this is fixed by adding an if statement to check if the object's index is -1, and skip over it if it is.
Optionally also delete the parent object (parent entity > child entity) if all child entities have an index of -1, but this will be automated when re-saving.