Make sure Poison is included in mix release builds#31
Open
troelsim wants to merge 1 commit intogaryf:masterfrom
Open
Make sure Poison is included in mix release builds#31troelsim wants to merge 1 commit intogaryf:masterfrom
troelsim wants to merge 1 commit intogaryf:masterfrom
Conversation
Since this library defines an explicit `applications` list in `mix.exs`, any dependency not in the list will not be included in a `mix release` build, unless it happens to be included by the parent project or another dependency. Since Poison is widely being replaced by Jason, this issue is becoming likely. This can be fixed by including `:poison` in `applications`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this library defines an explicit
applicationslist inmix.exs,any dependency not in the list will not be included in a
mix releasebuild, unless it happens to be included by the parent project or another
dependency. Since Poison is widely being replaced by Jason, this issue
is becoming likely.
This can be fixed by including
:poisoninapplications.