Skip to content

JsonWebToken.Algorithm.Hmac: Use :crypto.mac (OTP24) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lanodan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JsonWebToken.Algorithm.Hmac: Use :crypto.mac (OTP24) #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/json_web_token/algorithm/hmac.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ defmodule JsonWebToken.Algorithm.Hmac do
"""
def sign(sha_bits, shared_key, signing_input) do
validate_params(sha_bits, shared_key)
:crypto.hmac(sha_bits, shared_key, signing_input)
:crypto.mac(:hmac, sha_bits, shared_key, signing_input)
Copy link

@oivoodoo oivoodoo Jun 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lanodan

what about to have the code like that:

  if Code.ensure_loaded?(:crypto) and function_exported?(:crypto, :mac, 4) do
    defp hmac(type, key, data), do: :crypto.mac(:hmac, type, key, data)
  else
    defp hmac(type, key, data), do: :crypto.hmac(type, key, data)
  end

and then just call:

hmac(sha_bits, shared_key, signing_input)

https://github.com/elixir-ecto/postgrex/blob/master/lib/postgrex/scram.ex#L69

and it's definitely would be great to merge it as soon as possible. but it looks like the library has no active support.

end

@doc """
Expand Down