Skip to content

feat(browse): add geolocation CDP override methods to allowlist #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cl0ckt0wer wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

feat(browse): add geolocation CDP override methods to allowlist #1470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions browse/src/cdp-allowlist.ts
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,25 @@ export const CDP_ALLOWLIST: ReadonlyArray<CdpAllowEntry> = Object.freeze([
output: 'trusted',
justification: 'UA override on the active tab. NOTE: changes affect future requests; fine for tests.',
},
{
domain: 'Emulation',
method: 'setGeolocationOverride',
scope: 'tab',
output: 'trusted',
justification: 'Geolocation override on the active tab. Same threat profile as setDeviceMetricsOverride: pure input, no data exfiltration. Enables GPS testing.',
},
{
domain: 'Emulation',
method: 'clearGeolocationOverride',
scope: 'tab',
output: 'trusted',
justification: 'Clear geolocation override. Mirrors clearDeviceMetricsOverride for cleanup symmetry.',
},
// NOTE: Browser.grantPermissions is intentionally NOT added here. It is a
// browser-scope CDP method that cannot be forwarded through the page-level
// CDPSession that the browse bridge uses. Geolocation testing requires either
// a Playwright script (which grants permissions at context creation) or a
// future browser-scope CDP routing path in the bridge.
// ─── Page capture (output, not navigation) ─────────────────
{
domain: 'Page',
Expand Down