feat: design review lite in /review and /ship + gstack-diff-scope (v0.6.3)#142
Merged
feat: design review lite in /review and /ship + gstack-diff-scope (v0.6.3)#142
Conversation
bin/gstack-diff-scope categorizes branch changes into SCOPE_FRONTEND, SCOPE_BACKEND, SCOPE_PROMPTS, SCOPE_TESTS, SCOPE_DOCS, SCOPE_CONFIG. review/design-checklist.md is a 20-item code-level checklist with HIGH/MEDIUM/LOW confidence tags for detecting design anti-patterns from source code.
Add generateDesignReviewLite() resolver, insert {{DESIGN_REVIEW_LITE}}
partial in review Step 4.5 and ship Step 3.5. Update dashboard to
recognize design-review-lite entries. Ship pre-flight uses
gstack-diff-scope for smarter design review recommendations.
Planted CSS/HTML fixtures with 7 design anti-patterns. E2E test verifies /review catches >= 4 of 7 (Papyrus font, 14px body text, outline:none, !important, purple gradient, generic hero copy, 3-column feature grid).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/review(Step 4.5) and/ship(Step 3.5)!importantabusebin/gstack-diff-scopehelper categorizes branch changes (SCOPE_FRONTEND, SCOPE_BACKEND, SCOPE_PROMPTS, SCOPE_TESTS, SCOPE_DOCS, SCOPE_CONFIG)Test Coverage
Step 3.4: All new code paths have test coverage.
generateDesignReviewLite()→ covered by gen-skill-docs + skill-validation testsPre-Landing Review
No issues found.
Design Review
No frontend files changed — design review skipped.
Eval Results
No prompt-related files changed — evals skipped.
TODOS
gstack-diff-scopeprovides the infrastructure, dashboard conditional row display is remaining workTest plan
bun run gen:skill-docs— all 15 templates resolvebun test— all free tests pass (skill validation, gen-skill-docs, touchfiles)bun run skill:check— all skills healthygstack-diff-scope main— correctly categorizes changes🤖 Generated with Claude Code