Skip to content

feat: /plan-design-review + /qa-design-review skills (v0.5.0)#102

Open
garrytan wants to merge 11 commits intomainfrom
garrytan/design
Open

feat: /plan-design-review + /qa-design-review skills (v0.5.0)#102
garrytan wants to merge 11 commits intomainfrom
garrytan/design

Conversation

@garrytan
Copy link
Owner

Summary

  • /plan-design-review — Report-only designer audit: 10-category, 80-item design checklist with letter grades (A-F), dual headline Design Score + AI Slop Score, structured first impression critique, live design system extraction via JS, DESIGN.md inference/export offer, regression mode with design-baseline.json
  • /qa-design-review — Same audit, then iterative fix loop: style(design): FINDING-NNN commits, CSS-safe WTF heuristic (JSX/TSX +5%/file, CSS-only +0%, cap 30 fixes), before/after screenshots, final re-audit with score delta
  • {{DESIGN_METHODOLOGY}} resolver in gen-skill-docs.ts — shared methodology between both skills, following the {{QA_METHODOLOGY}} pattern
  • ~/.gstack-dev/plans/ as local plans directory for long-range vision docs
  • /setup-design-md added to TODOS.md (P2) for interactive DESIGN.md creation from scratch

Pre-Landing Review

No issues found.

TODOS

  • Added /setup-design-md (P2, L) under new ## Design Review section

Test plan

  • All 112 skill validation + gen-skill-docs tests pass (0 failures)
  • bun run skill:check — both new skills green (14 + 18 commands, all valid)
  • bun run gen:skill-docs — all 13 SKILL.md files generated and fresh

🤖 Generated with Claude Code

garrytan and others added 11 commits March 16, 2026 10:59
…skills

Add generateDesignMethodology() to gen-skill-docs.ts with 10-category, 80-item
design audit checklist. Register plan-design-review and qa-design-review templates
in findTemplates(). Add both skills to skill-check.ts SKILL_FILES. Add command
and snapshot flag validation tests for both skills in skill-validation.test.ts.
/plan-design-review: report-only designer audit with letter grades, AI slop
scoring, structured first impression, design system extraction, DESIGN.md
inference and export offer. Never modifies code.

/qa-design-review: same audit, then iterative fix loop with style(design):
commits, CSS-safe WTF heuristic, before/after screenshots, final re-audit.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update skill count to 11, add /plan-design-review and /qa-design-review
  to skill table, install/uninstall commands, and demo walkthrough
- Add narrative sections: "senior designer mode" and "designer who codes mode"
  with compelling examples showing AI Slop detection and design system inference
- Add {{DESIGN_METHODOLOGY}} to ARCHITECTURE.md placeholder table
- Extend demo to show full plan→eng→review→ship→qa→design-review pipeline

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Picks up BASE_BRANCH_DETECT resolver and updated contributor mode from main.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… DESIGN.md

6-phase consultant flow: product context → competitive research (WebSearch) →
complete coherent proposal → drill-downs on demand → font+color preview page →
write DESIGN.md + update CLAUDE.md. Opinionated recommendations grounded in
product context, not menu-driven forms.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…dge)

Tests 1-4: /design-consultation (core flow, research integration, existing
DESIGN.md handling, font+color preview generation).
Tests 5-6: /plan-design-review (audit report, DESIGN.md export).
Test 7: /qa-design-review (audit + fix loop).
LLM judge validates font blacklist compliance, coherence, and AI slop avoidance.
Also adds plan-design-review + qa-design-review to ALL_SKILLS test array.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Renamed from /setup-design-md to reflect the consultant approach.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolves conflicts in 7 files: CHANGELOG, README, TODOS, VERSION,
gen-skill-docs.ts, skill-check.ts, skill-validation.test.ts.
Regenerated all SKILL.md files after merge.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant