fix: add err handling 4 when sAMAccountName is NoneType#14
Open
mr-pmillz wants to merge 1 commit intogarrettfoster13:mainfrom
Open
fix: add err handling 4 when sAMAccountName is NoneType#14mr-pmillz wants to merge 1 commit intogarrettfoster13:mainfrom
mr-pmillz wants to merge 1 commit intogarrettfoster13:mainfrom
Conversation
Owner
|
Well that's interesting, thanks for the PR! |
Author
No problem! 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add err handling 4 when sAMAccountName is NoneType
This resolves what would otherwise result in a crash and incomplete execution when an empty sAMAccountName is encountered
Also, removed an empty space in
self. credsvar name which seemed unintended.With Patch:
