This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Open
Conversation
…en is not successful.
|
Same problem here, I have just made some tests with @t-knapp code, and it works. |
|
@t-knapp can we have this feature flagged? so this only kicks off if the flag is true. This PR is exactly what I feel was missing from this package. Thanks for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello folks,
I face a problem with
autoRefreshenabled. If thetokenEndpointresponds with non-success http status code, the response body is still stored in localStorage. The value is not a validAuthTokensobject and crashes thejwt-decodecall. Since the token values are read from localStorage, the app won't work even when reloading the whole page. Only fix is to remove the 'auth' value from localStorage.If the response from
tokenEndpointis http 400 e.g. if the refresh_token expired (see: OIDC API Doc for tokenEndpoint https://connect2id.com/products/server/docs/api/token#overview), the response body should not be stored. Instead, a full login cycle should be kicked off.It's a little bit tricky to reproduce - I mocked the http request on the
tokenEndpointto the IDP (Keycloak in my case) with a Chrome Extension https://github.com/mukuljainx/Mokku This is the body I returned in the mockThe fix proposed in this PR will start a new login cycle.
Kind regards,
Tobias