make suffix in s3 artifact manifest not contain cname #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to parse this correctly in GLCI
| sha256sum = file_digest(fp, "sha256").hexdigest() | ||
|
|
||
| if artifact.name.startswith(cname): | ||
| suffix = artifact.name[len(cname) :] |
There was a problem hiding this comment.
Curious choice, I would do artifacte.name.replace(cname, '') but I like the smiley :]
Contributor
Author
There was a problem hiding this comment.
Both solutions will work of course ;)
moritzkirchnersap
approved these changes
Jul 10, 2025
yeoldegrove
added a commit
to gardenlinux/gardenlinux
that referenced
this pull request
Jul 10, 2025
yeoldegrove
added a commit
to gardenlinux/gardenlinux
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make suffix in s3 artifact manifest not contain cname
Which issue(s) this PR fixes:
gardenlinux/gardenlinux@09ea136 and a7545af introduced a breaking change that breaks GLCI.