Skip to content

Conversation

@yeoldegrove
Copy link
Contributor

@yeoldegrove yeoldegrove commented Sep 1, 2025

What this PR does / why we need it:

Introduce $major.$minor.$patch fields into GLRD.
Look at gardenlinux/gardenlinux#3343 and gardenlinux/gardenlinux#3069.

  • Also renames every release according to the new naming conventions:
    • old: stable -> new: major
    • old: patch -> new: minor
    • new: patch

Which issue(s) this PR fixes:
Fixes gardenlinux/gardenlinux#3343

@yeoldegrove yeoldegrove self-assigned this Sep 1, 2025
@yeoldegrove yeoldegrove force-pushed the feat/semver branch 6 times, most recently from 77dbb66 to a1717eb Compare September 1, 2025 09:13
F401 - Unused imports: Removed atexit, base64, re, time, json, and pathlib.Path
F403/F405 - Star imports: Replaced all from module import * with explicit imports:
glrd.util: Now imports specific symbols like DEFAULTS, ERROR_CODES, etc.
python_gardenlinux_lib: Now imports specific functions like parse_flavors_commit, get_s3_artifacts
F841 - Unused variables: Fixed unused variables like minor, micro, e, merged_releases, formatted_change
F541 - F-strings without placeholders: Converted f-strings to regular strings where no placeholders were used
F811 - Redefinition: Fixed variable redefinitions
F821 - Undefined names: Fixed test cases where result was being used but assigned to _
F824 - Unused global: Commented out unused global variable
E303 - Extra blank lines: Fixed excessive blank lines
E501 - line too long
@yeoldegrove yeoldegrove requested a review from 5kt October 8, 2025 10:37
@yeoldegrove yeoldegrove added the enhancement New feature or request label Oct 8, 2025
@yeoldegrove yeoldegrove added this to the 2025-10 milestone Oct 8, 2025
@yeoldegrove yeoldegrove marked this pull request as ready for review October 8, 2025 10:37
@yeoldegrove yeoldegrove merged commit 8770c00 into main Oct 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLRD support for 3 segment semver compliant version for GL

3 participants