-
Notifications
You must be signed in to change notification settings - Fork 132
Fix scaling logic in reconcileNewMachineSetInPlace #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elankath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix.
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
|
/remove-lifecycle stale |
|
@aaronfern Command |
aaronfern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
/lgtm
takoverflow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! LGTM
Already addressed review comments
What this PR does / why we need it:
Adds a check to ensure the new machine set is scaled up when the combined replicas of old and new machine sets are less than the desired deployment replicas. This basically ensures that if a machine is deleted manually from the old machine sets, a new machine should be created in the new machine set with the updated configuration.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: