feat(backend): add namespaced-cloud-profile-support #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klocke-io
requested review from
grolu,
holgerkoser and
petersutter
as code owners
gardener-robot
added
needs/review
klocke-io
force-pushed
the
feature/namespaced-cloud-profile-support
branch
2 times, most recently
from
0e2f369 to
a561dff
Compare
klocke-io
force-pushed
the
feature/namespaced-cloud-profile-support
branch
from
a561dff to
674686f
Compare
|
@holgerkoser, @grolu You have pull request review open invite, please check |
grolu
added
area/ipcei
petersutter
reviewed
Dec 8, 2025
| '/projects': projectsRoute, | ||
| '/namespaces/:namespace/shoots': shootsRoute, | ||
| '/namespaces/:namespace/tickets': ticketsRoute, | ||
| '/namespaces/:namespace/cloudprofiles': namespacedCloudProfilesRoute, |
Member
There was a problem hiding this comment.
let's align closer to the gardener API (/apis/core.gardener.cloud/v1beta1/namespaces/garden-core/namespacedcloudprofiles)
Suggested change
| '/namespaces/:namespace/cloudprofiles': namespacedCloudProfilesRoute, | |
| '/namespaces/:namespace/namespacedcloudprofiles': namespacedCloudProfilesRoute, |
| import { metricsRoute } from '../middleware.js' | ||
| const { cloudprofiles } = services | ||
|
|
||
| const router = express.Router({ mergeParams: true }) |
Contributor
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
gardener-robot
added
the
lifecycle/stale
Contributor
|
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle rotten |
gardener-robot
added
lifecycle/rotten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for namespacedcloudprofiles
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Let's discuss how we want to access the
namespacedCloudprofiles, specifically whether we should retrieve them through the cache, as in the current implementation, or obtain them directly.I also deleted the
readfunction frombackend/lib/services/cloudprofiles.jssince it seemed to me that the function was not exposed. But happy to add it back, if she is needed, or if I misunderstood something.Release note: