This repository was archived by the owner on May 26, 2023. It is now read-only.
ocm command and some ctf cmd extension#59
Open
mandelsoft wants to merge 2 commits intogardener-attic:mainfrom
Open
ocm command and some ctf cmd extension#59mandelsoft wants to merge 2 commits intogardener-attic:mainfrom
mandelsoft wants to merge 2 commits intogardener-attic:mainfrom
Conversation
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
ghost
removed
the
reviewed/ok-to-test
gardener-robot
added
size/l
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
ghost
removed
the
reviewed/ok-to-test
jschicktanz
suggested changes
Jan 12, 2022
| "github.com/gardener/component-cli/pkg/logger" | ||
| ) | ||
|
|
||
| // Options defines the options that are used to add resources to a component descriptor |
Contributor
There was a problem hiding this comment.
Docstring seems misleading to me
| func main() { | ||
| ctx := context.Background() | ||
| defer ctx.Done() | ||
| cmd := app.NewComponentsCliCommand(ctx) |
Contributor
There was a problem hiding this comment.
Should we also rename the function from NewComponentsCliCommand() to NewOCMCliCommand() ?
| Property string | ||
| } | ||
|
|
||
| // NewGetCommand creates a command to add additional resources to a component descriptor. |
Contributor
There was a problem hiding this comment.
Docstring seems misleading to me
| cmd := &cobra.Command{ | ||
| Use: "get COMPONENT_ARCHIVE_PATH [options...]", | ||
| Args: cobra.MinimumNArgs(1), | ||
| Short: "set some component descriptor properties", |
Contributor
There was a problem hiding this comment.
Doc seems misleading to me
| Args: cobra.MinimumNArgs(1), | ||
| Short: "set some component descriptor properties", | ||
| Long: ` | ||
| the set command sets some component descriptor properies like the component name and/or version. |
Contributor
There was a problem hiding this comment.
Doc seems misleading to me
|
|
||
| func TestConfig(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Resources Test Suite") |
Contributor
There was a problem hiding this comment.
Suggested change
| RunSpecs(t, "Resources Test Suite") | |
| RunSpecs(t, "Component Archive Set Test Suite") |
| RunSpecs(t, "Resources Test Suite") | ||
| } | ||
|
|
||
| var _ = Describe("Set", func() { |
Contributor
There was a problem hiding this comment.
Suggested change
| var _ = Describe("Set", func() { | |
| var _ = Describe("Get", func() { |
| type PushOptions struct { | ||
| // CTFPath is the path to the directory containing the ctf archive. | ||
| CTFPath string | ||
| // CTFPaths is the path to the directory containing the ctf archive. |
Contributor
There was a problem hiding this comment.
Suggested change
| // CTFPaths is the path to the directory containing the ctf archive. | |
| // CTFPaths is the list of paths to the directories containing the ctf archives. |
| Args: cobra.ExactArgs(1), | ||
| Use: "push <CTF_PATH> ...", | ||
| Args: cobra.MinimumNArgs(1), | ||
| Short: "Pushes all archives of a ctf to a remote repository", |
Contributor
There was a problem hiding this comment.
Suggested change
| Short: "Pushes all archives of a ctf to a remote repository", | |
| Short: "Pushes one or more ctf archives to a remote repository", |
| Args: cobra.MinimumNArgs(1), | ||
| Short: "Pushes all archives of a ctf to a remote repository", | ||
| Long: ` | ||
| Push pushes all component archives and oci artifacts to the defined oci repository. |
Contributor
There was a problem hiding this comment.
Suggested change
| Push pushes all component archives and oci artifacts to the defined oci repository. | |
| Push pushes one or more ctf archives (including all component archives and oci artifacts) to a remote repository. |
gardener-robot
added
the
lifecycle/stale
gardener-robot
added
lifecycle/rotten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: