Skip to content

Update hashfunction.c to use gap_all.h#156

Merged
fingolfin merged 1 commit into
gap-packages:masterfrom
ptrrsn:patch-1
Jun 21, 2025
Merged

Update hashfunction.c to use gap_all.h#156
fingolfin merged 1 commit into
gap-packages:masterfrom
ptrrsn:patch-1

Conversation

@ptrrsn
Copy link
Copy Markdown
Contributor

@ptrrsn ptrrsn commented Jun 21, 2025

No description provided.

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 21, 2025

Context: gap-system/gap#6007

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (b852d76) to head (2cee45e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          35       35           
  Lines        2696     2696           
  Branches      110      110           
=======================================
  Hits         2567     2567           
  Misses        109      109           
  Partials       20       20           
Files with missing lines Coverage Δ
src/hashfunctions.c 93.95% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 479dbb7 into gap-packages:master Jun 21, 2025
8 checks passed
@fingolfin
Copy link
Copy Markdown
Member

Actually most gap_all.h includes can also ago (just did that on master)

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 21, 2025

Thank you for your review! Do you mind explaining more about what you mean here?

@fingolfin
Copy link
Copy Markdown
Member

fingolfin commented Jun 21, 2025

See 679b68e

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 21, 2025

Thank you!

@ptrrsn
Copy link
Copy Markdown
Contributor Author

ptrrsn commented Jun 22, 2025

cc @dimpase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants