Skip to content

WIP: Refactor the low-level interfaces#38

Draft
fingolfin wants to merge 1 commit into
masterfrom
mh/refactor-low-level-interface
Draft

WIP: Refactor the low-level interfaces#38
fingolfin wants to merge 1 commit into
masterfrom
mh/refactor-low-level-interface

Conversation

@fingolfin

Copy link
Copy Markdown
Member

We can do some things more efficiently in OSCAR if we work with somewhat higher level in- and outputs

We can do some things more efficiently in OSCAR if we work with somewhat higher level in- and outputs
@codecov

codecov Bot commented Feb 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.83%. Comparing base (1085195) to head (64efeb1).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
gap/pari.gi 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   77.83%   77.83%           
=======================================
  Files          19       19           
  Lines        1561     1561           
=======================================
  Hits         1215     1215           
  Misses        346      346           
Files with missing lines Coverage Δ
gap/field.gi 87.23% <100.00%> (+0.07%) ⬆️
gap/pari.gi 97.00% <88.88%> (-0.85%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread gap/oscar.gi

# convert to GAP
eqn := EquationOrderBasis(F);
b := List( T, x -> LinearCombination( eqn, x ) );

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this just shifted code around (and even duplicated it, once for OSCAR and once for PARI). The real idea here is that instead of asking OSCAR for coordinates in one basis and then we convert it here, instead we can directly get the desired coords from OSCAR.

But I've not yet done it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant