Skip to content

Fix large download retries #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ganto merged 2 commits into from
Mar 28, 2026
Merged

Fix large download retries #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3360dab
server: Disable Echo v5's default WriteTimeout to fix truncated downl…
ganto Mar 28, 2026
717fede
Changelog: Prepare release v0.1.2
ganto Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [Unreleased](https://github.com/ganto/pkgproxy/commits/HEAD/)

## [v0.1.2](https://github.com/ganto/pkgproxy/releases/tag/v0.1.2) - 2026-03-28

### Fixed

- Disable Echo v5's default 30-second `WriteTimeout` which killed streaming responses for large package files

## [v0.1.1](https://github.com/ganto/pkgproxy/releases/tag/v0.1.1) - 2026-03-25

### Added
Expand Down
11 changes: 11 additions & 0 deletions cmd/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"context"
"fmt"
"log/slog"
"net/http"
"os"
"os/signal"
"runtime"
Expand Down Expand Up @@ -126,6 +127,16 @@ func startServer(_ *cobra.Command, _ []string) error {
sc := echo.StartConfig{
Address: fmt.Sprintf("%s:%d", listenAddress, listenPort),
HideBanner: true,
BeforeServeFunc: func(s *http.Server) error {
// Echo v5 defaults WriteTimeout to 30s as Slowloris mitigation
// (GoSec G112). WriteTimeout is a hard wall-clock deadline from
// request header read to response completion, which cuts off
// streaming responses for large package files. If pkgproxy is
// exposed directly, use a reverse proxy (e.g. nginx) with
// appropriate timeouts for Slowloris protection.
s.WriteTimeout = 0
return nil
},
}
return sc.Start(ctx, app)
}
Loading