Skip to content

Update README updating deepClone function to include case where arrays inside objects were being converted to plain objects during cloning #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
div360 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Update README updating deepClone function to include case where arrays inside objects were being converted to plain objects during cloning #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ var newObject = deepClone(obj);

```javascript
function deepClone(object){
var newObject = {};
var newObject = Array.isArray(object) ? [] : {};
for(var key in object){
if(typeof object[key] === 'object' && object[key] !== null ){
newObject[key] = deepClone(object[key]);
Expand Down Expand Up @@ -1201,6 +1201,8 @@ var personalDetail = {
```
So when we do deep clone then we should copy every property (including the nested object).

Without `Array.isArray()` check, `[1, 2, 3]` was silently cloned as `{ "0": 1, "1": 2, "2": 3 }` since both arrays and objects return `"object"` for `typeof`,fixed by initializing `newObject` as `[]` when the input is an array

</details>

## Question 30. Best way to detect `undefined` object property in JavaScript.
Expand Down