Add illuminator_telescope_visibility model parameter schema#2220
Add illuminator_telescope_visibility model parameter schema#2220orelgueta wants to merge 2 commits into
Conversation
Define schema for telescope-illuminator visibility tables used in calibration simulations. Supports both North (~13 telescopes) and South (~60 telescopes) sites with boolean illumination status per telescope-illuminator pair.
There was a problem hiding this comment.
Pull request overview
Adds a new model-parameter schema describing an external ECSV visibility table that maps illuminators to telescope illumination status, intended for calibration simulations at CTAO North/South.
Changes:
- Introduce
illuminator_telescope_visibilityschema YAML undersrc/simtools/schemas/model_parameters/. - Add a changelog fragment documenting the new schema.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/simtools/schemas/model_parameters/illuminator_telescope_visibility.schema.yml | New schema definition for illuminator↔telescope visibility (file-backed parameter). |
| docs/changes/2220.feature.md | Changelog entry for the new schema. |
|
GernotMaier
left a comment
GernotMaier
left a comment
There was a problem hiding this comment.
See my comment in https://gitlab.cta-observatory.org/cta-science/simulations/simulation-model/simulation-models/-/merge_requests/135
Note that this suggested change would also allow to actually validate the columns and make it easier to not safe the file in the DB but the table in json.
Define schema for telescope-illuminator visibility tables used in calibration simulations. Supports both North (~13 telescopes) and South (~60 telescopes) sites with boolean illumination status per telescope-illuminator pair.