Collect CORSIKA limits plots#2219
Open
GernotMaier wants to merge 19 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the simtools-run-application collection feature to support glob patterns and multiple output-path collection entries, and reshapes CORSIKA-limits plot filenames so glob patterns can target meaningful subsets. Also moves the CORSIKA limits output table layout into a schema file and drops event_data_file from the output columns.
Changes:
_copy_collection_filesaccepts a list of{output_path, files}entries and_find_collection_fileshandles glob patterns recursively, with collision detection on the destination basename.- Plot filenames for triggered histograms get a
_triggeredoverride, and optionally includearray_name,z<zenith>,az<azimuth>,nsb<level>from the limits dict. - CORSIKA limits result columns / descriptions / file-info mappings are now read from a new
corsika_limits_table.schema.yml;event_data_filecolumn removed; production subdirectory naming simplified to prefer the parent directory name.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/simtools/runners/simtools_runner.py | Glob/list collection logic with collision detection. |
| src/simtools/visualization/plot_simtel_event_histograms.py | Filename overrides for triggered histograms and metadata-based filename suffix. |
| src/simtools/production_configuration/derive_corsika_limits.py | Schema-driven RESULT_COLUMNS/FILE_INFO_COLUMNS; simplified subdir naming. |
| src/simtools/applications/production_derive_corsika_limits.py | Doc table updated (drops event_data_file). |
| src/simtools/schemas/corsika_limits_table.schema.yml | New schema defining CORSIKA limits output table. |
| src/simtools/schemas/model_parameter_and_data_schema.metaschema.yml | Allows optional file_info_key on TableColumn. |
| tests/unit_tests/runners/test_simtools_runner.py | Tests for glob/list collection, collisions, and skips. |
| tests/unit_tests/visualization/test_plot_simtel_event_histograms.py | Tests for new filename helpers and triggered overrides. |
| tests/unit_tests/production_configuration/test_derive_corsika_limits.py | Tests for schema-driven mappings and removed event_data_file. |
| tests/integration_tests/config/plot_simulated_event_distributions.yml | Updated expected triggered 2D filename. |
| docs/changes/2203.feature.md, docs/changes/2219.feature.md | Changelog fragments. |
Comment on lines
+121
to
+122
| if isinstance(collection_config, dict): | ||
| collection_config = [collection_config] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update the file collection feature for simtools-run-application:
e.g., we can have now:
Update and improve the file naming such that the intended patterns actually work (and to not collect all files).