Add schema for corsika limits table.#2203
Open
GernotMaier wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated schema file for the production_derive_corsika_limits output table and aligns generated outputs/documentation by removing the obsolete event_data_file column from the produced limits table.
Changes:
- Added
corsika_limits_table.schema.ymldescribing the CORSIKA limits ECSV output table columns and units. - Removed
event_data_filefrom the derived limits result columns and updated unit tests accordingly. - Updated the application’s documented output-column list and added a changelog fragment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit_tests/production_configuration/test_derive_corsika_limits.py | Updates expectations to confirm event_data_file is no longer written to the results table. |
| src/simtools/schemas/corsika_limits_table.schema.yml | New schema describing the production_derive_corsika_limits output table structure. |
| src/simtools/production_configuration/derive_corsika_limits.py | Drops event_data_file from the output table column list. |
| src/simtools/applications/production_derive_corsika_limits.py | Removes event_data_file from the documented output table columns. |
| docs/changes/2203.feature.md | Changelog fragment for the new schema addition. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a schema for the CORSIKA limits output table. Remove obsolete event_files column from the tables.