Skip to content

chore: update dependencies and switch to typescript 6#13

Merged
gameroman merged 4 commits into
mainfrom
typescript-6
Mar 30, 2026
Merged

chore: update dependencies and switch to typescript 6#13
gameroman merged 4 commits into
mainfrom
typescript-6

Conversation

@gameroman
Copy link
Copy Markdown
Owner

@gameroman gameroman commented Mar 30, 2026

Summary by CodeRabbit

  • Chores

    • Updated development tooling and dependencies (Biome, TypeScript, Babel, and others)
    • Switched lint script to run the check command
    • Delegated project config to shared configs and added a shared config package
  • Refactor

    • Tightened local variable immutability across code paths
    • Simplified some internal control flow and configuration files
    • Aligned type declarations for boolean parameters
  • Tests

    • Adjusted test build options for fixture generation

@gameroman gameroman self-assigned this Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 012f0f5f-4218-4efb-833c-35ed48666a66

📥 Commits

Reviewing files that changed from the base of the PR and between 3c78387 and 9dc6a96.

📒 Files selected for processing (7)
  • biome.jsonc
  • src/babel-plugin-jsx-dom-expressions/babel-plugin-jsx-dom-expressions/shared/validate.ts
  • src/babel-plugin-jsx-dom-expressions/dom-expressions/client.js
  • src/babel-plugin-jsx-dom-expressions/dom-expressions/jsx-update.mjs
  • src/plugin-transform-typescript/namespace.ts
  • src/plugin-transform-typescript/plugin-syntax-typescript.ts
  • tests/COVERAGE.txt
✅ Files skipped from review due to trivial changes (4)
  • src/babel-plugin-jsx-dom-expressions/dom-expressions/jsx-update.mjs
  • src/plugin-transform-typescript/plugin-syntax-typescript.ts
  • tests/COVERAGE.txt
  • src/babel-plugin-jsx-dom-expressions/babel-plugin-jsx-dom-expressions/shared/validate.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/plugin-transform-typescript/namespace.ts
  • biome.jsonc
  • src/babel-plugin-jsx-dom-expressions/dom-expressions/client.js

📝 Walkthrough

Walkthrough

Updated tooling/configs and dependency versions, delegated configs to @gameroman/config, tightened several TypeScript declarations, replaced many local let bindings with const, adjusted runtime error/warning gating in dom-expressions client, and modified test/build options.

Changes

Cohort / File(s) Summary
Project configs
biome.jsonc, tsconfig.json
Switch to extends: ["@gameroman/config/..."], removed many local settings, added biome.files.includes and left only select compilerOptions; moved config responsibility to shared package.
Package manifest
package.json
Bumped dev/tooling and Babel deps, added @gameroman/config, tightened peerDependencies, and changed lint script from biome lintbiome check.
Runtime dom-expressions (client & server)
src/.../dom-expressions/client.js, src/.../dom-expressions/server.js
Removed DX-gated warnings/errors so certain hydration/missing-element errors are now thrown unconditionally; several loop/temp letconst changes.
Type declarations (dom-expressions)
src/.../dom-expressions/client.d.ts, src/.../dom-expressions/server.d.ts
Changed optional isSVG and skipChildren types from boxed Boolean → primitive boolean in spread and assign signatures.
Babel plugin implementation
src/babel-plugin-jsx-dom-expressions/...
Multiple local letconst updates across dom, ssr, universal, shared modules; no control-flow or AST output changes.
TypeScript transform plugin
src/plugin-transform-typescript/index.ts, src/plugin-transform-typescript/namespace.ts, src/plugin-transform-typescript/plugin-syntax-typescript.ts
Removed redundant block scopes, simplified identifier computation and destructuring (varconst), preserving semantics.
tsdown & build/test helpers
tsdown.config.ts, tests/helpers/index.ts
Removed explicit entry in tsdown config; added experimental: { attachDebugInfo: "none" } to rolldown build calls in tests.
Scripts/tooling modules
src/babel-plugin-jsx-dom-expressions/dom-expressions/jsx-update.mjs
Replaced imports with Node scheme (node:child_process, node:fs).
Validation & comments
src/.../shared/validate.ts
Adjusted lint/TS directive comments around a non-null assertion; no runtime change.
Coverage report
tests/COVERAGE.txt
Updated coverage totals and uncovered line ranges; report-only changes.
Formatting/lint overrides
biome.jsonc
Introduced extends: ["@gameroman/config/biome"], removed vcs, formatter, assist entries, changed rules: added suspicious warnings and other rule adjustments.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐇
I nibbled at lets and planted const seeds,
Configs grew roots where shared wisdom leads.
Types trimmed tidy, scripts hopped anew,
Hydration now stern — no whisper, just view.
Hooray — the rabbit polishes the queue!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 5.88% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary changes: TypeScript version bump to 6 and dependency updates throughout the changeset, including biome, babel, and dev tooling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typescript-6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman merged commit 387adae into main Mar 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant