Skip to content

Dev#224

Merged
gameknife merged 21 commits intomainfrom
dev
Jan 25, 2026
Merged

Dev#224
gameknife merged 21 commits intomainfrom
dev

Conversation

@gameknife
Copy link
Owner

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @gameknife, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive refactoring of the project's core infrastructure. It modernizes the build system for better feature control, automates the acquisition of external libraries, and centralizes rendering visualization settings for improved developer experience. These changes aim to enhance maintainability, simplify development workflows, and lay a stronger foundation for future feature development and debugging.

Highlights

  • Build System Refactoring with CMake Presets: The build system has been significantly overhauled to use a new CMake preset structure, introducing 'minimal', 'default', and 'full' feature sets. This allows for more flexible and granular control over enabled features like AVIF, DLSS, OIDN, and QuickJS, simplifying the build process across different platforms.
  • Automated External Dependency Management: Manual fetching scripts for external dependencies such as NVIDIA Streamline, Intel OIDN, TypeScript Compiler (TSC), and MoltenVK have been replaced. CMake's FetchContent module now automatically downloads and configures these libraries, streamlining project setup and reducing maintenance overhead.
  • Centralized Rendering Show Flags: A new ShowFlags struct has been introduced to centralize various rendering debug and visualization options (e.g., wireframe, debug lighting, bounding boxes). This improves UI consistency, code organization, and simplifies how these flags are accessed and managed throughout the engine and editor.
  • Physics System Enhancements: The Jolt Physics integration now includes a new HIDDEN object layer, allowing physics bodies to exist without colliding with moving objects. Physics body management has been improved with a new RemoveBody function and refined SetBodyActive logic, enhancing control over physics interactions.
  • Rendering Pipeline Optimizations: The wireframe rendering pipeline has been re-enabled and integrated. Skinned mesh updates are now more efficient, only processing animations that are actively playing and utilizing a request queue to manage model updates, reducing unnecessary computations.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/ios.yml
    • .github/workflows/linux.yml
    • .github/workflows/macos.yml
    • .github/workflows/release.yml
    • .github/workflows/windows.yml
    • .github/workflows/windows_self.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and beneficial refactoring of the build system, migrating to CMake Presets and FetchContent for dependency management. This greatly improves the project's structure, portability, and maintainability. Additionally, the introduction of a ShowFlags struct to separate display-related settings from general user settings is a good architectural improvement. My review includes a few suggestions for code formatting to enhance readability and a critical fix for the build.sh script to ensure its robustness.

- introduce opencode
- refine the code review suggestion
- clean glsl totally
- visualtest by claude
- asset cmake clean by claude
@gameknife gameknife merged commit d4a6bd3 into main Jan 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant