Conversation
…Joints/Weights attributes)
…kinning propagation
- add rig.glb for test
- engine shutdown / start circle in single process
- Introduced `src/Runtime/NextPhysicsTypes.h` to define `Next*` physics types (aliases to Jolt types or dummy structs). - Updated `src/Runtime/NextPhysics.h/cpp` to use `NextPhysicsTypes.h`. - Updated `src/Assets/Scene.hpp/cpp` to use `NextPhysicsTypes.h` and remove direct Jolt includes. - Guarded Jolt-specific implementation details with `#if WITH_PHYSIC`. - Ensured `NextPhysics` interface remains consistent regardless of `WITH_PHYSIC` setting.
- Introduced `src/Runtime/NextPhysicsTypes.h` to define `Next*` physics types (aliases to Jolt types or dummy structs). - Updated `src/Runtime/NextPhysics.h/cpp` to use `NextPhysicsTypes.h`. - Updated `src/Assets/Scene.hpp/cpp` to use `NextPhysicsTypes.h` and remove direct Jolt includes. - Guarded Jolt-specific implementation details with `#if WITH_PHYSIC`. - Ensured `NextPhysics` interface remains consistent regardless of `WITH_PHYSIC` setting. - Fixed compilation issues by ensuring `MeshShape.h` is included when `WITH_PHYSIC` is enabled.
…05888870917794659 Refactor physics system to fully decouple Jolt dependency
…hysicsComponent, and SkinnedMeshComponent.' as complete
…derComponent, PhysicsComponent, and SkinnedMeshComponent.'
…, PhysicsComponent, and SkinnedMeshComponent.'
Summary of ChangesHello @gameknife, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 本次拉取请求对引擎的核心架构进行了重大改进，通过引入组件化系统，极大地提升了 Node 类的模块化和可扩展性。同时，集成了 glTF 骨骼动画支持，为引擎带来了更丰富的动态内容表现能力。此外，音频和脚本引擎被重构为独立的模块，进一步优化了代码组织和维护性。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring to a component-based architecture for Node objects, adds comprehensive glTF skinned animation support, and improves code organization by encapsulating engine functionalities into dedicated helper and manager classes. The changes also include updated agent guidance documentation and new unit tests for the component system, physics, and glTF skinning. Overall, the changes enhance modularity, extend engine capabilities, and improve maintainability.
1 participant
No description provided.