Refactor physics system to fully decouple Jolt dependency#222
Conversation
- Introduced `src/Runtime/NextPhysicsTypes.h` to define `Next*` physics types (aliases to Jolt types or dummy structs). - Updated `src/Runtime/NextPhysics.h/cpp` to use `NextPhysicsTypes.h`. - Updated `src/Assets/Scene.hpp/cpp` to use `NextPhysicsTypes.h` and remove direct Jolt includes. - Guarded Jolt-specific implementation details with `#if WITH_PHYSIC`. - Ensured `NextPhysics` interface remains consistent regardless of `WITH_PHYSIC` setting.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Introduced `src/Runtime/NextPhysicsTypes.h` to define `Next*` physics types (aliases to Jolt types or dummy structs). - Updated `src/Runtime/NextPhysics.h/cpp` to use `NextPhysicsTypes.h`. - Updated `src/Assets/Scene.hpp/cpp` to use `NextPhysicsTypes.h` and remove direct Jolt includes. - Guarded Jolt-specific implementation details with `#if WITH_PHYSIC`. - Ensured `NextPhysics` interface remains consistent regardless of `WITH_PHYSIC` setting. - Fixed compilation issues by ensuring `MeshShape.h` is included when `WITH_PHYSIC` is enabled.
1 participant
Refactored the physics integration to support complete removal of Jolt Physics when
WITH_PHYSIC=0.Introduced an abstraction layer
NextPhysicsTypes.hwhich provides aliases to Jolt types when enabled, and compatible dummy types when disabled.Refactored
NextPhysicsandSceneclasses to use these abstract types, ensuring no Jolt headers are included in the build when physics is disabled.PR created automatically by Jules for task 8505888870917794659 started by @gameknife