Document orchestrator test filter injection#574
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds documentation for a Test Workflow Engine: introduces API inputs for test suites and injected filters, expands the YAML suite/run schema with reusable ChangesTest Workflow Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
docs/03-github-orchestrator/05-api-reference.mdxOops! Something went wrong! :( ESLint: 10.3.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by docs/03-github-orchestrator/07-advanced-topics/11-test-workflow-engine.mdxOops! Something went wrong! :( ESLint: 10.3.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 1286fd6): https://game-ci-5559f--pr574-docs-test-filter-inj-jz20i1sc.web.app (expires Fri, 22 May 2026 02:07:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1f0574f15f83e11bfc148eae8646486a6d0e078b |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/03-github-orchestrator/07-advanced-topics/11-test-workflow-engine.mdx (1)
232-267: ⚡ Quick winClarify filter merge precedence for injected overlays.
Please explicitly document the application order between suite-level refs, injected
refs/filters, and run-localfilterRefs/filters(for example on Line 232 and in the table around Line 262). Without this, users can’t reliably predict final filter behavior when all three are present.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/03-github-orchestrator/07-advanced-topics/11-test-workflow-engine.mdx` around lines 232 - 267, Add an explicit statement that explains the merge/precedence order for filters: when resolving the final filters, start from the suite file's own refs and filters, then apply the injected overlay's refs, filters and filterSets (overlaying/merging on top of suite values), and finally apply run-local inputs (testFilterRefs and testFilterInjection) which take highest precedence and override or extend earlier settings; also clarify how named refs are expanded and how conflicting keys (refs, filters.names, filters.categories, filterSets) are merged (injection merges/overwrites suite, run-local merges/overwrites injection). Reference the YAML inputs shown (testSuitePath, testFilterRefs, testFilterInjection, testFilterInjectionPath) and terms used in the doc (refs, filters, filterSets) so readers can locate the behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/03-github-orchestrator/07-advanced-topics/11-test-workflow-engine.mdx`:
- Around line 232-267: Add an explicit statement that explains the
merge/precedence order for filters: when resolving the final filters, start from
the suite file's own refs and filters, then apply the injected overlay's refs,
filters and filterSets (overlaying/merging on top of suite values), and finally
apply run-local inputs (testFilterRefs and testFilterInjection) which take
highest precedence and override or extend earlier settings; also clarify how
named refs are expanded and how conflicting keys (refs, filters.names,
filters.categories, filterSets) are merged (injection merges/overwrites suite,
run-local merges/overwrites injection). Reference the YAML inputs shown
(testSuitePath, testFilterRefs, testFilterInjection, testFilterInjectionPath)
and terms used in the doc (refs, filters, filterSets) so readers can locate the
behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e90d4e65-1415-4e3e-90c4-9278535a8af5
📒 Files selected for processing (2)
docs/03-github-orchestrator/05-api-reference.mdxdocs/03-github-orchestrator/07-advanced-topics/11-test-workflow-engine.mdx
| suites as YAML configurations - specifying exactly which tests run for each CI event, filtered by | ||
| taxonomy metadata, with sequential execution dependencies. | ||
| suites as YAML configurations: specifying exactly which tests run for each CI event, filtered by | ||
| Unity categories and test names, with sequential execution dependencies. |
There was a problem hiding this comment.
Instead of Unity should we use Game Engines here and in other places?

Summary
testFilter*inputs-testCategoryand-testFilterVerification
yarn buildyarn tsc --noEmitSummary by CodeRabbit