Open
Conversation
dmoka
reviewed
Apr 15, 2026
| let owner = pallet_intent::Pallet::<T>::intent_owner(id).ok_or(Error::<T>::IntentOwnerNotFound)?; | ||
| pallet_intent::Pallet::<T>::unlock_funds(&owner, intent.asset_in(), intent.amount_in())?; | ||
|
|
||
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), unlock and transfer amounts, owner: {:?}, asset: {:?}, amount: {:?}", |
Contributor
There was a problem hiding this comment.
Suggested change
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), unlock and transfer amounts, owner: {:?}, asset: {:?}, amount: {:?}", | |
| log::debug!(target: LOG_TARGET, "{:?}: submit_solution(), unlock and transfer amounts, owner: {:?}, asset: {:?}, amount: {:?}", |
dmoka
reviewed
Apr 15, 2026
|
|
||
| match t.direction { | ||
| SwapType::ExactOut => { | ||
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), buying, asset_in: {:?}, asset_out: {:?}, amount_out: {:?}, max_amount_in: {:?}, route: {:?}", |
Contributor
There was a problem hiding this comment.
Suggested change
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), buying, asset_in: {:?}, asset_out: {:?}, amount_out: {:?}, max_amount_in: {:?}, route: {:?}", | |
| log::debug!(target: LOG_TARGET, "{:?}: submit_solution(), buying, asset_in: {:?}, asset_out: {:?}, amount_out: {:?}, max_amount_in: {:?}, route: {:?}", |
dmoka
reviewed
Apr 15, 2026
| )?; | ||
| } | ||
| SwapType::ExactIn => { | ||
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), selling, asset_in: {:?}, asset_out: {:?}, amount_in: {:?}, min_amount_out: {:?}, route: {:?}", |
Contributor
There was a problem hiding this comment.
Suggested change
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), selling, asset_in: {:?}, asset_out: {:?}, amount_in: {:?}, min_amount_out: {:?}, route: {:?}", | |
| log::debug!(target: LOG_TARGET, "{:?}: submit_solution(), selling, asset_in: {:?}, asset_out: {:?}, amount_in: {:?}, min_amount_out: {:?}, route: {:?}", |
dmoka
reviewed
Apr 15, 2026
| let fee_amount = Self::protocol_fee().mul_floor(resolve.amount_out()); | ||
| let payout = resolve.amount_out().saturating_sub(fee_amount); | ||
|
|
||
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), transferring, id: {:?}, to: {:?}, amount: {:?}, fee: {:?}", LOG_PREFIX, id, owner, payout, fee_amount); |
Contributor
There was a problem hiding this comment.
Suggested change
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), transferring, id: {:?}, to: {:?}, amount: {:?}, fee: {:?}", LOG_PREFIX, id, owner, payout, fee_amount); | |
| log::debug!(target: LOG_TARGET, "{:?}: submit_solution(), transferring, id: {:?}, to: {:?}, amount: {:?}, fee: {:?}", LOG_PREFIX, id, owner, payout, fee_amount); |
dmoka
reviewed
Apr 15, 2026
| let intent = pallet_intent::Pallet::<T>::get_intent(id).ok_or(Error::<T>::IntentNotFound)?; | ||
| let surplus = pallet_intent::Pallet::<T>::compute_surplus(&intent, resolve) | ||
| .ok_or(Error::<T>::ArithmeticOverflow)?; | ||
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), id: {:?}, surplus: {:?}", LOG_PREFIX, id, surplus); |
Contributor
There was a problem hiding this comment.
Suggested change
| log::debug!(target: LOG_TARGET, "{:?}: sumbit_solution(), id: {:?}, surplus: {:?}", LOG_PREFIX, id, surplus); | |
| log::debug!(target: LOG_TARGET, "{:?}: submit_solution(), id: {:?}, surplus: {:?}", LOG_PREFIX, id, surplus); |
dmoka
reviewed
Apr 15, 2026
| let call = Call::cleanup_intent { id: *intent_id }; | ||
| let tx = T::create_bare(call.into()); | ||
| if let Err(e) = SubmitTransaction::<T, Call<T>>::submit_transaction(tx) { | ||
| debug_assert!(false, "laxy-executorn: failed to submit dispatch_top transaction"); |
Contributor
There was a problem hiding this comment.
Suggested change
| debug_assert!(false, "laxy-executorn: failed to submit dispatch_top transaction"); | |
| debug_assert!(false, "laxy-executor: failed to submit dispatch_top transaction"); |
Rolling DCA schedules (total_amount = 0) were being prematurely terminated when the price of the bought asset increased after schedule creation. The remaining_amount (set once at creation, never updated for rolling schedules) would become smaller than the recalculated amount_for_next_trade, triggering completion even though the user had plenty of funds. Skip both budget termination checks for rolling schedules since their budget is infinite by definition.
mrq1911
reviewed
Apr 17, 2026
|
|
||
| parameter_types! { | ||
| //24 hours | ||
| pub const MaxIntentDuration: u64 = 24 * 3_600 * 1_000; |
Contributor
There was a problem hiding this comment.
yes, you can create intent without deadline or withing this limit
| } | ||
|
|
||
| parameter_types! { | ||
| pub const IcePalletId: PalletId = PalletId(*b"ice_ice#"); |
Member
There was a problem hiding this comment.
Suggested change
| pub const IcePalletId: PalletId = PalletId(*b"ice_ice#"); | |
| pub const IcePalletId: PalletId = PalletId(*b"iceicebb"); |
| @@ -0,0 +1,4 @@ | |||
| mod mock; | |||
| mod ocw; | |||
Contributor
There was a problem hiding this comment.
these are offchain-worker(ocw) related tests
|
|
||
| #[pallet::storage] | ||
| /// Reverse index mapping account to its intent ids for easy lookup. | ||
| pub type AccountIntents<T: Config> = |
Member
There was a problem hiding this comment.
do we really need 3 maps? cannot we just store intents here where it preserve ownership as well? this way you are spending 3x reads and writes per intent bloat storage and take longer time to load into solver
|
|
||
| #[pallet::storage] | ||
| #[pallet::getter(fn intent_owner)] | ||
| pub(super) type IntentOwner<T: Config> = StorageMap<_, Blake2_128Concat, IntentId, T::AccountId>; |
Member
There was a problem hiding this comment.
if intent cannot change ower there is no reason to have separate map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces foundation of ICE - Intent Composing Engine.
Included: