types: optimize ResourceManager overload for type checking#2081
Open
MrKou47 wants to merge 1 commit intogalacean:mainfrom
Open
types: optimize ResourceManager overload for type checking#2081MrKou47 wants to merge 1 commit intogalacean:mainfrom
MrKou47 wants to merge 1 commit intogalacean:mainfrom
Conversation
Member
|
其实设计初衷确实是想用 EngineObject 严格规范的!但目前 resourceManager.load 还有个遗留缺陷待解决,AssetType 中有三个枚举 Text、JSON、Buffer 三种类型加载进来不是 EngineObject 并且和其他资产不一样无缓存机制,可以等把这个遗留问题解决后合并此 PR。 稍微了想了下,可以将三种类型统一抽象为 RawAsset(原始或未处理的资产,也继承 EngineObject),API 可参考 fetch 的 response 包含类似 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
type update
What is the current behavior? (You can also link to an open issue here)
Currently
engine.resourceManager.loadand the overloads could missing type checking due to the order of overloads. Like:What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.