Feature: Add alias for loading resource#1786
Open
HypnosNova wants to merge 6 commits intogalacean:mainfrom
Open
Feature: Add alias for loading resource#1786HypnosNova wants to merge 6 commits intogalacean:mainfrom
HypnosNova wants to merge 6 commits intogalacean:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1786 +/- ##
==========================================
+ Coverage 65.10% 65.11% +0.01%
==========================================
Files 473 473
Lines 23641 23654 +13
Branches 3362 3366 +4
==========================================
+ Hits 15392 15403 +11
Misses 7045 7045
- Partials 1204 1206 +2
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourceManager.getFromCache is very difficult to use. For example
Sometimes a resource url is a hash string and we don't know what is it util we check the resource by url. We can't know what is it when writing code. And another much worse situation is loading a spine, it has 3 urls and we must join the url array. The code would be very ugly.
If we give LoadItem a name, we can just get cache by their name, for example: