Add uniform decorator for improving custom material code#1713
Open
HypnosNova wants to merge 19 commits intogalacean:mainfrom
Open
Add uniform decorator for improving custom material code#1713HypnosNova wants to merge 19 commits intogalacean:mainfrom
HypnosNova wants to merge 19 commits intogalacean:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1713 +/- ##
===========================================
+ Coverage 61.37% 61.97% +0.59%
===========================================
Files 410 432 +22
Lines 21834 22447 +613
Branches 3140 3190 +50
===========================================
+ Hits 13401 13911 +510
- Misses 7244 7315 +71
- Partials 1189 1221 +32
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With uniform decorator, it will be easier for create uniform property in material class.
Features:
1. support define glsl variable name
2. support macro
3. support keeping reference