Skip to content

Update dep version #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cptbtptpbcptdtptp merged 1 commit into from
Sep 16, 2025
Merged

Update dep version #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"pnpm": {
"overrides": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
}
2 changes: 1 addition & 1 deletion packages/auxiliary-lines/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
},
"dependencies": {
"@galacean/engine-toolkit-custom-material": "workspace:*"
Expand Down
2 changes: 1 addition & 1 deletion packages/controls/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/custom-gltf-parser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/custom-material/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/draco/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
"types/**/*"
],
"dependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/dynamic-bone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/framebuffer-picker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/geometry-sketch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
4 changes: 2 additions & 2 deletions packages/gizmo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0",
"@galacean/engine-ui": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2",
"@galacean/engine-ui": "^1.6.0-alpha.2"
},
"dependencies": {
"@galacean/engine-toolkit-framebuffer-picker": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/input-logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/lines/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/navigation-gizmo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
},
"dependencies": {
"@galacean/engine-toolkit-controls": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/outline/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/skeleton-viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/stats/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
Copy link

@coderabbitai coderabbitai bot Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Alpha peerDependency is a breaking requirement; align release plan or widen the range.

Bumping the minimum peer to ^1.6.0-alpha.2 forces consumers onto a prerelease and breaks installs for users pinned to 1.5.x. Either:

  • publish this package as a matching prerelease (e.g., 1.6.0-alpha.x) to signal the break, or
  • widen the peer range if 1.5 remains compatible.

Option A (widen if compatible):

-    "@galacean/engine": "^1.6.0-alpha.2"
+    "@galacean/engine": ">=1.5.0 <2"

Option B (keep alpha minimum but be explicit):

-    "@galacean/engine": "^1.6.0-alpha.2"
+    "@galacean/engine": ">=1.6.0-alpha.2 <2"

Repo-wide verification script:

🏁 Script executed:

#!/bin/bash
set -euo pipefail
echo "Peer ranges for @galacean/engine:"
fd -a package.json | sort | xargs -I{} sh -c 'jq -r --arg f "{}" '"'"'[.name, .version, .peerDependencies["@galacean/engine"]] | @tsv'"'"' "{}" 2>/dev/null' | awk -F'\t' 'NF==3 {printf "%-55s %-12s %s\n",$1,$2,$3}'

echo
echo "Packages with version 1.5.x but peer >=1.6.0-*:"
fd -a package.json | xargs -I{} jq -r --arg f "{}" '[.name, .version, .peerDependencies["@galacean/engine"]] | @tsv' "{}" 2>/dev/null \
 | awk -F'\t' '$2 ~ /^1\.5\./ && $3 ~ /1\.6\.0/ {printf "%-55s %-12s %s\n",$1,$2,$3}'

Length of output: 3218

Fix prerelease peerDependency that breaks 1.5.x packages

Multiple packages at version 1.5.3 declare "@galacean/engine": "^1.6.0-alpha.2" — this forces consumers onto a prerelease and will break installs; either publish matching prereleases or widen the peer range.

Affected packages (package.json):

  • @galacean/engine-toolkit-auxiliary-lines
  • @galacean/engine-toolkit-controls
  • @galacean/engine-toolkit-custom-gltf-parser
  • @galacean/engine-toolkit-custom-material
  • @galacean/engine-toolkit-dynamic-bone
  • @galacean/engine-toolkit-framebuffer-picker
  • @galacean/engine-toolkit-geometry-sketch
  • @galacean/engine-toolkit-gizmo
  • @galacean/engine-toolkit-input-logger
  • @galacean/engine-toolkit-lines
  • @galacean/engine-toolkit-navigation-gizmo
  • @galacean/engine-toolkit-outline
  • @galacean/engine-toolkit-skeleton-viewer
  • @galacean/engine-toolkit-stats
  • @galacean/engine-toolkit-tween
  • @galacean/engine-toolkit-way-point
  • @galacean/engine-toolkit-xr

Recommended fixes (choose one):

Option A — widen peer range if 1.5.x is compatible:

-    "@galacean/engine": "^1.6.0-alpha.2"
+    "@galacean/engine": ">=1.5.0 <2"

Option B — keep alpha minimum but be explicit (publish prerelease packages to match):

-    "@galacean/engine": "^1.6.0-alpha.2"
+    "@galacean/engine": ">=1.6.0-alpha.2 <2"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@galacean/engine": "^1.6.0-alpha.2"
"@galacean/engine": ">=1.5.0 <2"
Suggested change
"@galacean/engine": "^1.6.0-alpha.2"
"@galacean/engine": ">=1.6.0-alpha.2 <2"
🤖 Prompt for AI Agents 
packages/stats/package.json (line 26): the peerDependency for "@galacean/engine"
is pinned to a prerelease (^1.6.0-alpha.2) which forces consumers onto an alpha
and breaks installs for 1.5.x; update the peerDependencies to either widen the
range to include stable 1.5 (e.g. "@galacean/engine": "^1.5.0 ||
^1.6.0-alpha.2") if 1.5.x is compatible, or intentionally require the prerelease
by publishing matching prerelease packages and keeping the current constraint
(choose one approach and apply consistently across the listed packages).

}
}
2 changes: 1 addition & 1 deletion packages/tween/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion packages/way-point/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2"
}
}
4 changes: 2 additions & 2 deletions packages/xr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"types/**/*"
],
"peerDependencies": {
"@galacean/engine": "^1.5.0",
"@galacean/engine-xr": "^1.5.0"
"@galacean/engine": "^1.6.0-alpha.2",
"@galacean/engine-xr": "^1.6.0-alpha.2"
}
}
2 changes: 1 addition & 1 deletion tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"types/**/*"
],
"dependencies": {
"@galacean/engine": "^1.5.0",
"@galacean/engine": "^1.6.0-alpha.2",
"@galacean/engine-toolkit-auxiliary-lines": "workspace:*",
"@galacean/engine-toolkit-controls": "workspace:*",
"@galacean/engine-toolkit-framebuffer-picker": "workspace:*"
Expand Down
Loading