Implement factory to fetch Card objects for manipulation#23
Open
rallu wants to merge 4 commits intogajus:masterfrom
Open
Implement factory to fetch Card objects for manipulation#23rallu wants to merge 4 commits intogajus:masterfrom
rallu wants to merge 4 commits intogajus:masterfrom
Conversation
|
👍 |
|
👍 that shoule be merged |
|
Will someone ever merge this? |
|
Any plans to have this functionality merged? |
Collaborator
|
I will check this PR and today if everything is right, I'll merge it. |
|
More then 1 month checking. Wow, pretty intensive testing |
|
Please merge this. Also, the non-angular version seems to have some new features, which would be nice to have in Angular version, too. |
|
@gajus @marcelaraujo - Merge yet? |
Collaborator
|
@LoganLehman I'll check and then merge. |
|
@marcelaraujo Thank you! |
|
Would be really cool to merge this PR |
|
Please merge!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created simple factory to fetch Swing.js Card objects.
Also implemented simple buttons to example to throw cards left and right.