Replacing GitVersion 5 with 6#529
Conversation
gaelcolas
left a comment
gaelcolas
left a comment
There was a problem hiding this comment.
Do we have to make it a breaking change?
If the template is not the same that's fine, but I feel existing repos can continue to work with gitversion v5.
There's another couple of points I'd like to discuss to clarify, but generally I think the way it works is ok.
Let's discuss...
Right, in this way it is not a breaking change. GitVersion 6 will only be used by projects created after the change. |
|
@gaelcolas, I have done the changes that we have discussed. |
…pler into feature/gitversion6
raandree
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… branch label
The version-bump-message regexes were missing the '+semver:' prefix,
causing any commit containing words like 'breaking' or 'feature' to
trigger unintended Major/Minor bumps (e.g. 0.114.0 -> 1.0.0).
The feature branch regex lacked the (?<BranchName>.+) named capture
group, so the '{BranchName}' label token was never resolved.
Changes:
- Add '\+semver:' prefix to major/minor/patch-version-bump-message
- Fix feature branch regex to '^features?[\/-](?<BranchName>.+)'
fix: pin Plaster to 1.1.4 to avoid breaking change in 2.0.0 Plaster 2.0.0 (published 2026-04-13) removed the internal function 'GetPlasterManifestPathForCulture', which breaks Add-Sample's dynamic parameter resolution and causes the 'SourceDirectory' parameter to not be found during tests. ```
|
@gaelcolas, I have rebased the branch. Can you have a look at it, please? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
FTR, I'll discuss with @raandree what to do as I'd rather avoid a breaking change, but updating a task would be good, or alternatively have the task pick up the version and decide on the behaviour. |
…on an AzDo agent Guard the ##vso[task.setvariable] and ##vso[build.updatebuildnumber] writes with a check for $env:TF_BUILD so local builds don't emit noisy Azure DevOps logging commands.
8 participants
Pull Request
Pull Request (PR) description
The is a breaking change that replaces the GitVersion 5 support with GitVersion 6. The schema for 6.3 is not compatible with 5.12.
GitVersion 6 does no longer support zero-padded versions like
3.0.1-preview0001, instead it looks like3.0.1-preview.1(FullSemVer). To be compatible with NuGet 2.0 (PowerShell, Chocolatey), the build taskGitVersiondoes the padding for pre-releases.References:
Added
GitVersion.ymlconfig file.GitVersion.Get-SamplerBuildVersionto be compatible with GitVersion 6.Get-SamplerBuildVersionPester tests.README.md.Changed
Manual Deployment.GitVersion.ymlconfig file to work with GitVersion 6.Task list
build.ps1 -ResolveDependency).This change is