Explicit cast for new[] size to unsigned #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without, we get warnings such as:
modelvariablevector.cc: In member function ‘resize’:
modelvariablevector.cc:26:59: warning: argument 1 value ‘18446744073709551615’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]
26 | ModelVariable* vnew = new ModelVariable[addsize + size];
| ^
/usr/include/c++/15/new:140:26: note: in a call to allocation function ‘operator new []’ declared here
140 | _GLIBCXX_NODISCARD void* operator new[](std::size_t)
| ^
...the aim is to make sure that we don't size an array bigger than a
signed int (which we use in gadget2 source).
To quell the warnings, explicitly cast to unsigned, first making sure
that any value isn't negative (which would cause wraparound).
This warning only occurs during LTO, add default arguments to trigger
it in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bthe I think this tidies up the warning that CRAN is complaining about.
The gadget3 integration tests still work, but it'd be worth trying a few more things before releasing.