Added a property to check if a meta description is present or not. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi! Thanks for your PR. Wouldnt |
Author
|
I'm not sure. Currently if there is no description present, it will look for the first paragraph and get the description from there. So there is no way to tell if the tag is present or not, since it will always be filled. I'm not sure what the !! operator does in this case. Still learning JS, so if I'm mistaken please enlighten me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to see if the page hold a meta description or not, since it retrieves the first paragraph if there is nothing present. I've added a parameter that holds information if there was a meta description present or not, depending on the outcome.