Skip to content

Added Madge Builder to graph commonJS/AMD dependencies. #4

Open
pixeldrew wants to merge 5 commits into
fzaninotto:masterfrom
pixeldrew:npmsetup-ff
Open

Added Madge Builder to graph commonJS/AMD dependencies. #4
pixeldrew wants to merge 5 commits into
fzaninotto:masterfrom
pixeldrew:npmsetup-ff

Conversation

@pixeldrew
Copy link
Copy Markdown

Added npm package.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.

pixeldrew added 5 commits May 21, 2014 18:34
…kage.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.
…kage.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.
Comment thread .npmignore
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit that file.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I created this file, is that during npm's publishing process it misses the dist folder due to it being in my .gitignore file. https://www.npmjs.org/doc/developers.html
You could create an empty .gitignore file so that it doesn't use by default what is in .gitignore.

@fzaninotto
Copy link
Copy Markdown
Owner

Sorry, I can't even review this PR. Please submit only atomic changes. Your PR mixes minification (which I don't need), package.json (why not), madge (why not). You should split it into separate PRs.

@pixeldrew
Copy link
Copy Markdown
Author

The minification is added as process of npm packaging. If you do not wish to add minification as part of npm's publishing process then by all means remove it.

@pixeldrew
Copy link
Copy Markdown
Author

I'll add the madgeBuilder as a separate PR. The package.json automates minification via the build.js script using the npm package command.

@pixeldrew
Copy link
Copy Markdown
Author

I moved the javascript to the lib folder to closer match to NPM best practice, this makes it difficult to give you atomic PR's.

The overall reason for this PR was so that DependencyWheel could be included into Cloudflare's JS CDN https://github.com/cdnjs/cdnjs. The package.json file includes the npmFile Map attribute that points to a built (dist) version of the library- only the files listed here are added to the CDN. Cloudflare has a requirement for minification, so I built that as part of the npm packaging process which makes it automated. All you should need to do to submit this package to npm is, after the package.json file has been merged to run the following commands:

npm install -d && npm adduser && npm package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants