Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 30, 2025

  • Analyze current .eslintrc configuration (old JSON format)
  • Create new eslint.config.mjs file in flat config format
  • Migrate all rules from .eslintrc to new format
  • Handle deprecated/removed rules:
    • no-catch-shadow → removed (covered by no-shadow)
    • no-native-reassign → replaced with no-global-assign
    • handle-callback-err → removed (now in eslint-plugin-n)
    • newline-after-var → replaced with padding-line-between-statements (now includes var, let, const)
    • no-reserved-keys → removed
    • no-wrap-func → removed
    • no-new-object → removed (now no-object-constructor but not used here)
  • Delete old .eslintrc file
  • Run ESLint to verify the new configuration works
  • Run code review and address feedback
  • Run security scan (codeql_checker) - no issues found
  • Change dotest version to ^2
Original prompt

Convert the current old ESlint config to the new config format. Create a PR with the changes.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 30, 2025 02:14
Co-authored-by: fvdm <93784+fvdm@users.noreply.github.com>
Co-authored-by: fvdm <93784+fvdm@users.noreply.github.com>
Copilot AI changed the title [WIP] Convert old ESLint config to new format Convert ESLint config to flat config format Nov 30, 2025
Copilot AI requested a review from fvdm November 30, 2025 02:17
@fvdm
Copy link
Owner

fvdm commented Nov 30, 2025

@copilot In devdeps change the 'dotest' version to ^2. I don't publish breaking changes in point releases of 'dotest'.

Co-authored-by: fvdm <93784+fvdm@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

@copilot In devdeps change the 'dotest' version to ^2. I don't publish breaking changes in point releases of 'dotest'.

Done in dd473d1.

@coveralls
Copy link

Coverage Status

coverage: 98.438%. remained the same
when pulling dd473d1 on copilot/update-eslint-config-format
into 167499f on develop.

@coveralls
Copy link

coveralls commented Nov 30, 2025

Coverage Status

coverage: 98.438%. remained the same
when pulling 299ad2a on copilot/update-eslint-config-format
into 56ad0cc on develop.

@fvdm
Copy link
Owner

fvdm commented Nov 30, 2025

@copilot Rebase the PR branch to develop

Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

@copilot Rebase the PR branch to develop

I'm unable to rebase the PR branch because I don't have access to force push, which is required after a rebase operation. You'll need to perform the rebase manually with:

git checkout copilot/update-eslint-config-format
git rebase develop
git push --force-with-lease origin copilot/update-eslint-config-format

I can't find a stable test case for the dateTime param
@fvdm
Copy link
Owner

fvdm commented Nov 30, 2025

@copilot Remove the '@eslint/js' and 'globals' devdeps. They are taken care of by 'dotest'.

Co-authored-by: fvdm <93784+fvdm@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

@copilot Remove the '@eslint/js' and 'globals' devdeps. They are taken care of by 'dotest'.

Done in 299ad2a.

@fvdm fvdm marked this pull request as ready for review November 30, 2025 04:30
@fvdm fvdm merged commit b144805 into develop Nov 30, 2025
14 checks passed
@fvdm fvdm deleted the copilot/update-eslint-config-format branch November 30, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants