fix: cgroup leak when delete container from pod#40
Open
zhaodiaoer wants to merge 1 commit intofuweid:unstablefrom
Open
fix: cgroup leak when delete container from pod#40zhaodiaoer wants to merge 1 commit intofuweid:unstablefrom
zhaodiaoer wants to merge 1 commit intofuweid:unstablefrom
Conversation
There are some situations that containerd(CRI) will be asked to delete containers from a pod which not terminated, for example, kubelet will clean initContainers before start pod(`pruneInitContainersBeforeStart`). Currently, TaskManager's `Delete` function only removes the task item from map, the container's resources like bundle and cgroup will leak on the host, this commit fixes this. Signed-off-by: Lei Liu <liulei.pt@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some situations that containerd(CRI) will be asked to delete containers from a pod which not terminated, for example, kubelet will clean initContainers before start pod(
pruneInitContainersBeforeStart).Currently,
TaskManager'sDeletefunction only removes the task item from map, the container's resources like bundle and cgroup will leak on the host, this commit fixes this.