Add Grayjay.Desktop.Web Flake#162
Open
elanorg wants to merge 2 commits intofuto-org:master-backupfrom
Open
Conversation
|
Please sign our contributor license agreement at https://cla.futo.org |
|
Please sign our contributor license agreement at https://cla.futo.org |
Author
|
On further consideration, I think it wise to restructure the stacked-branch scheme I had laid out. There will need to be a flake.nix in this repository's root, but there is no branch on which it can live and thus be merged into I'm closing this in favor of a different branch naming scheme is all. EDIT: I had to draw the whole thing out on a newly-acquired whiteboard, but I had my mental model backwards the entire time. This branch is fine as it is. Which is a little embarrassing, to be honest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've written and tested a flake.nix for Grayjay.Desktop.Web
It's not quite up to my standards, but it evaluates as expected. You can verify this to your own satisfaction by running
nix build ./Grayjay.Desktop.Webfrom the repo's root and digging through theresultsymlink. My intentions are to import this derivation as-is into the final packaged output of Grayjay.Desktop as a whole, a lacp -r ${pkgs.grayjay-desktop-web} $out/bin/wwwroot.Tip
To the maintainers:
I'll be following the "branch stacking" convention for these flakes, so it may be more convenient to merge a different branch, which should be mentioned below.
Note
Alejandra, my formatter of choice, only added support for
alejandra.tomlin v3.1.0Caution
Concerning
$out/lib:pkgs,lib.buildNpmPackageincludes node_modules in$out/lib, which takes up an obscene amount of space and is afaict totally unnecesary.fixupPhaseis a hacky workaround for this and I totally intend to fix it properly.